From 036fc195670ca136b32ffe03f0622d7fe6075217 Mon Sep 17 00:00:00 2001
From: Amatsugu <khamraj@kaisei.app>
Date: Fri, 27 Jun 2025 19:34:55 -0400
Subject: [PATCH] First person camera Input States

---
 src/components/camera.rs        |  11 ++
 src/main.rs                     |   1 +
 src/plugins/camera.rs           |  61 +++++++++++
 src/plugins/free_cam.rs         |  71 ------------
 src/plugins/game.rs             | 184 +++++++++++++-------------------
 src/plugins/mod.rs              |   5 +-
 src/plugins/player.rs           |  14 ++-
 src/plugins/state_management.rs |  16 +++
 src/plugins/types.rs            |   5 +-
 src/states/input.rs             |  20 ++++
 src/states/mod.rs               |   1 +
 11 files changed, 200 insertions(+), 189 deletions(-)
 create mode 100644 src/plugins/camera.rs
 delete mode 100644 src/plugins/free_cam.rs
 create mode 100644 src/plugins/state_management.rs
 create mode 100644 src/states/input.rs
 create mode 100644 src/states/mod.rs

diff --git a/src/components/camera.rs b/src/components/camera.rs
index e07c408..4b14887 100644
--- a/src/components/camera.rs
+++ b/src/components/camera.rs
@@ -37,3 +37,14 @@ impl Default for FollowTarget {
 		};
 	}
 }
+
+#[derive(Component, Default, Reflect)]
+pub enum CameraMode {
+	#[default]
+	Player,
+	Ship,
+	Disabled,
+}
+
+#[derive(Component, Reflect)]
+pub struct CameraAttachment(pub Entity);
diff --git a/src/main.rs b/src/main.rs
index aac9eae..01a0958 100644
--- a/src/main.rs
+++ b/src/main.rs
@@ -1,4 +1,5 @@
 mod plugins;
+mod states;
 mod utils;
 use bevy::{prelude::*, window::PresentMode};
 use bevy_inspector_egui::{bevy_egui::EguiPlugin, quick::WorldInspectorPlugin};
diff --git a/src/plugins/camera.rs b/src/plugins/camera.rs
new file mode 100644
index 0000000..056d7d4
--- /dev/null
+++ b/src/plugins/camera.rs
@@ -0,0 +1,61 @@
+use bevy::prelude::*;
+#[cfg(feature = "dev")]
+use bevy::window::PrimaryWindow;
+
+use crate::components::camera::*;
+
+pub struct CameraPlugin;
+
+impl Plugin for CameraPlugin {
+	fn build(&self, app: &mut App) {
+		app.add_systems(Update, camera_pitch);
+		app.add_systems(Update, camera_attachment);
+		#[cfg(feature = "dev")]
+		app.add_systems(Update, camera_toggle);
+	}
+}
+
+pub fn camera_attachment(
+	attachment_targets: Query<&GlobalTransform>,
+	cam: Single<(&mut Transform, &CameraAttachment, &CameraMode)>,
+) {
+	let (mut transform, attach, mode) = cam.into_inner();
+
+	if let Ok(tgt) = attachment_targets.get(attach.0) {
+		match mode {
+			CameraMode::Player => {
+				transform.rotation = tgt.rotation();
+				transform.translation = tgt.translation();
+			}
+			CameraMode::Ship => todo!("Ship Mode"),
+			CameraMode::Disabled => (),
+		}
+	}
+}
+
+pub fn camera_pitch(cam_query: Query<(&mut Transform, &CameraPitch)>) {
+	for (mut cam_transform, pitch) in cam_query {
+		cam_transform.rotation = Quat::from_rotation_x(pitch.0);
+	}
+}
+
+#[cfg(feature = "dev")]
+pub fn camera_toggle(
+	key: Res<ButtonInput<KeyCode>>,
+	mut window: Single<&mut Window, With<PrimaryWindow>>,
+	camera: Single<&mut CameraMode>,
+) {
+	use bevy::window::CursorGrabMode;
+	let mut mode = camera.into_inner();
+	if key.just_pressed(KeyCode::Escape) {
+		if window.cursor_options.visible {
+			*mode = CameraMode::Player;
+			window.cursor_options.grab_mode = CursorGrabMode::Locked;
+			window.cursor_options.visible = false;
+		} else {
+			*mode = CameraMode::Disabled;
+			window.cursor_options.grab_mode = CursorGrabMode::None;
+			window.cursor_options.visible = true;
+		}
+	}
+}
diff --git a/src/plugins/free_cam.rs b/src/plugins/free_cam.rs
deleted file mode 100644
index b3426f7..0000000
--- a/src/plugins/free_cam.rs
+++ /dev/null
@@ -1,71 +0,0 @@
-use std::f32::consts::FRAC_PI_2;
-
-use bevy::{input::mouse::MouseMotion, prelude::*};
-
-use crate::{components::camera::*, utils::input::get_mouse_delta};
-
-pub struct FreeCamPlugin;
-
-impl Plugin for FreeCamPlugin {
-	fn build(&self, app: &mut App) {
-		app.add_systems(Update, ((camera_yaw, camera_pitch).chain(), free_camera));
-	}
-}
-
-const FLY_SPEED: f32 = 10.0;
-pub fn free_camera(
-	cam_query: Single<(&mut Transform, &FreeCam), (With<CameraRoot>, Without<Unfocused>)>,
-	cam_pitch: Single<&CameraPitch>,
-	key: Res<ButtonInput<KeyCode>>,
-	time: Res<Time>,
-) {
-	let mut move_dir = Vec3::ZERO;
-	let pitch = cam_pitch.0;
-	let (mut cam_transform, freecam) = cam_query.into_inner();
-	if !freecam.0 {
-		return;
-	}
-	if key.pressed(KeyCode::KeyW) {
-		move_dir.z = -1.0;
-	} else if key.pressed(KeyCode::KeyS) {
-		move_dir.z = 1.0;
-	}
-
-	if key.pressed(KeyCode::KeyD) {
-		move_dir.x = 1.0;
-	} else if key.pressed(KeyCode::KeyA) {
-		move_dir.x = -1.0;
-	}
-
-	move_dir = cam_transform.rotation
-		* Quat::from_rotation_x(pitch)
-		* move_dir.normalize_or_zero()
-		* time.delta_secs()
-		* FLY_SPEED;
-
-	cam_transform.translation += move_dir;
-}
-
-pub fn camera_yaw(
-	cam_yaw_query: Single<(&mut Transform, &FreeCam), (With<CameraRoot>, Without<Unfocused>)>,
-	cam_query: Single<&mut CameraPitch>,
-	mouse_motion: EventReader<MouseMotion>,
-	time: Res<Time>,
-) {
-	let (mut yaw_transform, freecam) = cam_yaw_query.into_inner();
-	if !freecam.0 {
-		return;
-	}
-	let mut pitch = cam_query.into_inner();
-
-	let delta = get_mouse_delta(mouse_motion) * -time.delta_secs();
-
-	yaw_transform.rotate_y(delta.x);
-
-	pitch.0 = (pitch.0 + delta.y).clamp(-FRAC_PI_2 + 0.001, FRAC_PI_2 - 0.001);
-}
-
-pub fn camera_pitch(cam_query: Single<(&mut Transform, &CameraPitch)>) {
-	let (mut cam_transform, pitch) = cam_query.into_inner();
-	cam_transform.rotation = Quat::from_rotation_x(pitch.0);
-}
diff --git a/src/plugins/game.rs b/src/plugins/game.rs
index 16d2d40..e5cee22 100644
--- a/src/plugins/game.rs
+++ b/src/plugins/game.rs
@@ -1,10 +1,11 @@
 use crate::{
 	components::{
-		camera::{CameraPitch, CameraRoot, FollowCam, MainCamera, Unfocused},
-		player::{GravityDirection, MoveSpeed, PlayerDrag},
+		camera::{CameraAttachment, CameraMode, CameraPitch, FollowCam, MainCamera},
+		player::PlayerDrag,
 		tags::{Player, Ship},
 	},
-	plugins::*,
+	plugins::{state_management::StateManagementPlugin, *},
+	states::input::{InputState, PlayerState},
 };
 use bevy::{
 	prelude::*,
@@ -19,19 +20,18 @@ impl Plugin for GamePlugin {
 	fn build(&self, app: &mut bevy::app::App) {
 		app.add_plugins((
 			FollowCamPlugin,
+			CameraPlugin,
+			StateManagementPlugin,
 			// ShipPlugin,
 			TypesPlugin,
 			PlayerPlugin,
-			// CharacterControllerPlugin,
 		));
 		app.add_plugins((
 			RapierPhysicsPlugin::<NoUserData>::default(),
 			#[cfg(feature = "dev-phys")]
 			RapierDebugRenderPlugin::default(),
 		));
-		app.add_systems(Startup, (setup_scene).chain());
-
-		app.add_systems(Update, camera_toggle);
+		app.add_systems(Startup, (setup_scene, spawn_ship).chain());
 	}
 }
 
@@ -41,39 +41,37 @@ fn setup_scene(
 	mut materials: ResMut<Assets<StandardMaterial>>,
 	mut window: Single<&mut Window, With<PrimaryWindow>>,
 ) {
-	// window.cursor_options.visible = false;
-	// window.cursor_options.grab_mode = CursorGrabMode::Locked;
+	window.cursor_options.visible = false;
+	window.cursor_options.grab_mode = CursorGrabMode::Locked;
 
-	let player = commands
+	let player_eye = commands
 		.spawn((
-			Name::new("Player"),
-			Player,
-			PlayerDrag(0.5),
-			Collider::capsule_y(0.5, 0.5),
-			RigidBody::KinematicPositionBased,
-			KinematicCharacterController::default(),
-			Mesh3d(meshes.add(Capsule3d::new(0.5, 1.0))),
-			MeshMaterial3d(materials.add(Color::linear_rgb(1.0, 0.0, 0.2))),
-			Transform::from_translation(Vec3::new(0.0, 10.0, 10.0)),
+			Name::new("Eye"),
+			Transform::from_translation(Vec3::new(0.0, 1.0, 0.0)),
+			CameraPitch::default(),
 		))
 		.id();
+	let mut player_commands = commands.spawn((
+		Name::new("Player"),
+		Player,
+		PlayerDrag(0.5),
+		Collider::capsule_y(0.5, 0.5),
+		RigidBody::KinematicPositionBased,
+		KinematicCharacterController::default(),
+		Mesh3d(meshes.add(Capsule3d::new(0.5, 1.0))),
+		MeshMaterial3d(materials.add(Color::linear_rgb(1.0, 0.0, 0.2))),
+		Transform::from_translation(Vec3::new(0.0, 10.0, 10.0)),
+	));
+	player_commands.add_child(player_eye);
 
 	commands.spawn((
-		Name::new("Camera Root"),
+		Name::new("Camera"),
 		Transform::from_xyz(0.0, 1.3, 0.0),
-		CameraRoot,
 		Visibility::default(),
-		FollowCam {
-			distance: 20.,
-			height: 10.,
-			target: player,
-		},
-		children![(
-			Camera3d::default(),
-			CameraPitch::default(),
-			MainCamera,
-			Transform::default()
-		)],
+		MainCamera,
+		Camera3d::default(),
+		CameraMode::Player,
+		CameraAttachment(player_eye),
 	));
 
 	commands.spawn((
@@ -102,84 +100,56 @@ fn spawn_ship(
 	mut commands: Commands,
 	mut meshes: ResMut<Assets<Mesh>>,
 	mut materials: ResMut<Assets<StandardMaterial>>,
-	camera: Single<Entity, With<MainCamera>>,
 ) {
 	let window_material = materials.add(Color::linear_rgba(1.0, 0.0, 1.0, 0.5));
 
 	let material = materials.add(Color::BLACK);
 
-	let ship = commands
-		.spawn((
-			Mesh3d(meshes.add(Cuboid::new(3.0, 0.1, 6.0))),
-			MeshMaterial3d(material.clone()),
-			Name::new("Ship"),
-			Ship,
-			Velocity::zero(),
-			Damping::default(),
-			Transform::from_xyz(0.0, 1.0, 0.0),
-			RigidBody::Dynamic,
-			children![
-				(
-					Name::new("Back Wall"),
-					Mesh3d(meshes.add(Cuboid::new(3.0, 2.0, 0.1))),
-					Collider::cuboid(3.0, 2.0, 0.1),
-					MeshMaterial3d(material.clone()),
-					Transform::from_xyz(0.0, 1.0, 6.0 / 2.0),
-				),
-				(
-					Name::new("Front Window"),
-					Mesh3d(meshes.add(Cuboid::new(3.0, 2.0, 0.1))),
-					Collider::cuboid(3.0, 2.0, 0.1),
-					MeshMaterial3d(window_material),
-					Transform::from_xyz(0.0, 1.0, -6.0 / 2.0),
-				),
-				(
-					Name::new("Right Wall"),
-					Mesh3d(meshes.add(Cuboid::new(0.1, 2.0, 6.0))),
-					Collider::cuboid(0.1, 2.0, 6.0),
-					MeshMaterial3d(material.clone()),
-					Transform::from_xyz(3.0 / 2.0, 1.0, 0.0),
-				),
-				(
-					Name::new("Left Wall"),
-					Mesh3d(meshes.add(Cuboid::new(0.1, 2.0, 6.0))),
-					Collider::cuboid(0.1, 2.0, 6.0),
-					MeshMaterial3d(material.clone()),
-					Transform::from_xyz(-3.0 / 2.0, 1.0, 0.0),
-				),
-				(
-					Name::new("Roof"),
-					Mesh3d(meshes.add(Cuboid::new(3.0, 0.1, 6.0))),
-					Collider::cuboid(3.0, 0.1, 6.0),
-					MeshMaterial3d(material.clone()),
-					Transform::from_xyz(0.0, 2.0, 0.0),
-				)
-			],
-		))
-		.id();
-
-	commands.entity(camera.into_inner()).insert(FollowCam {
-		distance: 20.,
-		height: 10.,
-		target: ship,
-	});
-}
-
-pub fn camera_toggle(
-	key: Res<ButtonInput<KeyCode>>,
-	mut window: Single<&mut Window, With<PrimaryWindow>>,
-	camera: Single<Entity, With<CameraRoot>>,
-	mut commands: Commands,
-) {
-	if key.just_pressed(KeyCode::Escape) {
-		if window.cursor_options.visible {
-			commands.entity(camera.into_inner()).remove::<Unfocused>();
-			window.cursor_options.grab_mode = CursorGrabMode::Locked;
-			window.cursor_options.visible = false;
-		} else {
-			commands.entity(camera.into_inner()).insert(Unfocused);
-			window.cursor_options.grab_mode = CursorGrabMode::None;
-			window.cursor_options.visible = true;
-		}
-	}
+	commands.spawn((
+		Mesh3d(meshes.add(Cuboid::new(3.0, 0.1, 6.0))),
+		MeshMaterial3d(material.clone()),
+		Name::new("Ship"),
+		Ship,
+		Velocity::zero(),
+		Damping::default(),
+		Transform::from_xyz(0.0, 1.0, 0.0),
+		RigidBody::Dynamic,
+		children![
+			(
+				Name::new("Back Wall"),
+				Mesh3d(meshes.add(Cuboid::new(3.0, 2.0, 0.1))),
+				Collider::cuboid(3.0, 2.0, 0.1),
+				MeshMaterial3d(material.clone()),
+				Transform::from_xyz(0.0, 1.0, 6.0 / 2.0),
+			),
+			(
+				Name::new("Front Window"),
+				Mesh3d(meshes.add(Cuboid::new(3.0, 2.0, 0.1))),
+				Collider::cuboid(3.0, 2.0, 0.1),
+				MeshMaterial3d(window_material),
+				Transform::from_xyz(0.0, 1.0, -6.0 / 2.0),
+			),
+			(
+				Name::new("Right Wall"),
+				Mesh3d(meshes.add(Cuboid::new(0.1, 2.0, 6.0))),
+				Collider::cuboid(0.1, 2.0, 6.0),
+				MeshMaterial3d(material.clone()),
+				Transform::from_xyz(3.0 / 2.0, 1.0, 0.0),
+			),
+			(
+				Name::new("Left Wall"),
+				Mesh3d(meshes.add(Cuboid::new(0.1, 2.0, 6.0))),
+				Collider::cuboid(0.1, 2.0, 6.0),
+				MeshMaterial3d(material.clone()),
+				Transform::from_xyz(-3.0 / 2.0, 1.0, 0.0),
+			),
+			(
+				Name::new("Roof"),
+				Mesh3d(meshes.add(Cuboid::new(3.0, 0.1, 6.0))),
+				Collider::cuboid(3.0, 0.1, 6.0),
+				MeshMaterial3d(material.clone()),
+				Transform::from_xyz(0.0, 2.0, 0.0),
+			)
+		],
+	));
 }
diff --git a/src/plugins/mod.rs b/src/plugins/mod.rs
index 4001a46..316ba6e 100644
--- a/src/plugins/mod.rs
+++ b/src/plugins/mod.rs
@@ -1,15 +1,16 @@
 // mod character_controller;
+mod camera;
 mod follow_cam;
-mod free_cam;
 mod game;
 mod player;
 mod ship;
 mod ship_cam;
+mod state_management;
 mod types;
 
 // pub use character_controller::*;
+pub use camera::*;
 pub use follow_cam::*;
-pub use free_cam::*;
 pub use game::*;
 pub use player::*;
 pub use ship::*;
diff --git a/src/plugins/player.rs b/src/plugins/player.rs
index 724bfc6..2f4d462 100644
--- a/src/plugins/player.rs
+++ b/src/plugins/player.rs
@@ -1,17 +1,16 @@
-use std::f32::EPSILON;
+use std::f32::{EPSILON, consts::FRAC_PI_2};
 
 use bevy::{input::mouse::MouseMotion, prelude::*};
 use bevy_rapier3d::prelude::*;
 
 use crate::{
 	components::{
+		camera::CameraPitch,
 		player::{GravityDirection, JumpSpeed, MoveSpeed, PlayerDrag, PlayerForce, PlayerMotion, PlayerVelocity},
 		tags::Player,
 	},
-	utils::{
-		input::get_mouse_delta,
-		rotation::{get_alignment_rotation, get_alignment_rotation_preserve_twist},
-	},
+	states::input::PlayerInputSystems,
+	utils::{input::get_mouse_delta, rotation::get_alignment_rotation_preserve_twist},
 };
 
 pub struct PlayerPlugin;
@@ -24,9 +23,6 @@ impl Plugin for PlayerPlugin {
 	}
 }
 
-#[derive(SystemSet, Debug, Clone, PartialEq, Eq, Hash)]
-pub struct PlayerInputSystems;
-
 fn apply_forces(player: Single<(&mut PlayerVelocity, &PlayerForce), With<Player>>, time: Res<Time>) {
 	let (mut vel, force) = player.into_inner();
 
@@ -129,12 +125,14 @@ fn keyboard_input(
 
 fn player_look(
 	mut player: Single<&mut Transform, With<Player>>,
+	mut cam_pitch: Single<&mut CameraPitch>,
 	mouse_motion: EventReader<MouseMotion>,
 	time: Res<Time>,
 ) {
 	let delta = get_mouse_delta(mouse_motion) * -time.delta_secs();
 	let up = player.up();
 	player.rotate_axis(up, delta.x);
+	cam_pitch.0 = (cam_pitch.0 + delta.y).clamp(-FRAC_PI_2 + 0.001, FRAC_PI_2 - 0.001);
 }
 
 fn align_with_gravity(
diff --git a/src/plugins/state_management.rs b/src/plugins/state_management.rs
new file mode 100644
index 0000000..f932a4b
--- /dev/null
+++ b/src/plugins/state_management.rs
@@ -0,0 +1,16 @@
+use bevy::prelude::*;
+
+use crate::states::input::{InputState, PlayerInputSystems, PlayerState};
+
+pub struct StateManagementPlugin;
+
+impl Plugin for StateManagementPlugin {
+	fn build(&self, app: &mut App) {
+		app.init_state::<PlayerState>();
+		app.init_state::<InputState>();
+
+		app.configure_sets(PreUpdate, PlayerInputSystems.run_if(in_state(InputState::World)));
+		app.configure_sets(Update, PlayerInputSystems.run_if(in_state(InputState::World)));
+		app.configure_sets(PostUpdate, PlayerInputSystems.run_if(in_state(InputState::World)));
+	}
+}
diff --git a/src/plugins/types.rs b/src/plugins/types.rs
index 53ed24a..da25731 100644
--- a/src/plugins/types.rs
+++ b/src/plugins/types.rs
@@ -1,7 +1,7 @@
 use bevy::prelude::*;
 
 use crate::components::{
-	camera::{FollowCam, FollowTarget},
+	camera::{CameraAttachment, CameraMode, CameraPitch, FollowCam, FollowTarget},
 	player::{GravityDirection, MoveSpeed, PlayerForce, PlayerMotion, PlayerVelocity},
 };
 
@@ -16,5 +16,8 @@ impl Plugin for TypesPlugin {
 		app.register_type::<PlayerMotion>();
 		app.register_type::<GravityDirection>();
 		app.register_type::<MoveSpeed>();
+		app.register_type::<CameraPitch>();
+		app.register_type::<CameraAttachment>();
+		app.register_type::<CameraMode>();
 	}
 }
diff --git a/src/states/input.rs b/src/states/input.rs
new file mode 100644
index 0000000..1cc1b4a
--- /dev/null
+++ b/src/states/input.rs
@@ -0,0 +1,20 @@
+use bevy::prelude::*;
+
+#[derive(States, Debug, Default, Clone, PartialEq, Eq, Hash)]
+pub enum InputState {
+	#[default]
+	World,
+	Menu,
+	Detached,
+}
+
+#[derive(SystemSet, Debug, Clone, PartialEq, Eq, Hash)]
+pub struct PlayerInputSystems;
+
+#[derive(States, Debug, Default, Clone, PartialEq, Eq, Hash)]
+pub enum PlayerState {
+	#[default]
+	OnFoot,
+	FreeFloating,
+	Piloting,
+}
diff --git a/src/states/mod.rs b/src/states/mod.rs
new file mode 100644
index 0000000..7839bc5
--- /dev/null
+++ b/src/states/mod.rs
@@ -0,0 +1 @@
+pub mod input;